fix: Ensure CLI works out-of-the-box on Node 16+ #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 814f8e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
fix/node-opts-16+
branch
from
8e228fb
to
814f8e8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bit of a hacky fix
Did you add tests for your changes?
No
Summary
We've had a lot of issues regarding Webpack failing on Node 16+: #1643, #1688, #1748, #1773
Edit: Also has come up on Slack at least once
Rather than continue to field the same questions, this PR injects the necessary config (
NODE_OPTIONS=--openssl-legacy-provider) if this is one of our templates and the user's Node version is above v16.0.0.It's a bit hacky, but gets the job done.
Does this PR introduce a breaking change?
No, only affects newly created projects for users on Node versions greater than v16.0.0