New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Github actions to latest versions #90
chore: Update Github actions to latest versions #90
Conversation
@estherkim Did you previous PR solve your deprecation warning? |
@developit @JoviDeCroock Please review? |
Are you seriously tagging me for something you just opened? |
I don't know who reviews changes in this repo. You approved the last PR that was supposed to resolve this issue so you seemed like a likely candidate? Sorry if I broke some protocol. |
Tagging people is generally a way to get attention if something has gone unnoticed for a while. Most of us have some sort of notifications set up and will get to things eventually. So tagging specific people for a review less than 10 minutes after opening can be seen as a bit rude in any OSS project, as maintaining this stuff isn't our day job or anything we're really paid for. It's something we do in our free time, when we can. It comes off as a bit demanding, which is what I think Jovi was hinting at. Rest assured, someone will take a look eventually. |
…5748) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [preactjs/compressed-size-action](https://togithub.com/preactjs/compressed-size-action) | action | minor | `2.5.0` -> `2.6.0` | --- ### Release Notes <details> <summary>preactjs/compressed-size-action (preactjs/compressed-size-action)</summary> ### [`v2.6.0`](https://togithub.com/preactjs/compressed-size-action/releases/tag/2.6.0) [Compare Source](https://togithub.com/preactjs/compressed-size-action/compare/2.5.0...2.6.0) #### New Features / Improvements - \[feature] Add install script inputs by [@​jeffreys-cat](https://togithub.com/jeffreys-cat) in [preactjs/compressed-size-action#85 - feat: Add support for more precise percentage changes by [@​mister-ben](https://togithub.com/mister-ben) in [preactjs/compressed-size-action#97 - Add support for Bun by [@​jack-weilage](https://togithub.com/jack-weilage) in [preactjs/compressed-size-action#104 #### Action Maintenance - Update action.yml to use node16 by [@​estherkim](https://togithub.com/estherkim) in [preactjs/compressed-size-action#87 - Move to node20, release v3 by [@​jonny-puma](https://togithub.com/jonny-puma) in [preactjs/compressed-size-action#103 #### Repo Maintenance - Fix typo by [@​denniskigen](https://togithub.com/denniskigen) in [preactjs/compressed-size-action#86 - chore: Update Github actions to latest versions by [@​mmckenziedev](https://togithub.com/mmckenziedev) in [preactjs/compressed-size-action#90 - chore: Bump package-lock.json by [@​rschristian](https://togithub.com/rschristian) in [preactjs/compressed-size-action#105 #### New Contributors - [@​denniskigen](https://togithub.com/denniskigen) made their first contribution in [preactjs/compressed-size-action#86 - [@​estherkim](https://togithub.com/estherkim) made their first contribution in [preactjs/compressed-size-action#87 - [@​mmckenziedev](https://togithub.com/mmckenziedev) made their first contribution in [preactjs/compressed-size-action#90 - [@​jack-weilage](https://togithub.com/jack-weilage) made their first contribution in [preactjs/compressed-size-action#104 - [@​jonny-puma](https://togithub.com/jonny-puma) made their first contribution in [preactjs/compressed-size-action#103 - [@​mister-ben](https://togithub.com/mister-ben) made their first contribution in [preactjs/compressed-size-action#97 - [@​jeffreys-cat](https://togithub.com/jeffreys-cat) made their first contribution in [preactjs/compressed-size-action#85 - [@​rschristian](https://togithub.com/rschristian) made their first contribution in [preactjs/compressed-size-action#105 **Full Changelog**: preactjs/compressed-size-action@2.5.0...2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The Github actions
actions/checkout@v2
andactions/setup-node@v1
need to be updated to the latest versions to be in compliance with Github's node@12 deprecation. I believe the following warning is due to these actions being out of date.I don't think #87 fully solved this problem
From the link:
In my own projects I updated these actions to the latest major versions and the deprecation warning went away.
I imagine this change would be a major version upgrade as I had to add these new versions to my project's allowed list of actions, otherwise I receive this warning and the actions fail to execute.