Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Github actions to latest versions #90

Merged
merged 1 commit into from Apr 23, 2023

Conversation

mmckenziedev
Copy link
Contributor

@mmckenziedev mmckenziedev commented Apr 18, 2023

The Github actions actions/checkout@v2 and actions/setup-node@v1 need to be updated to the latest versions to be in compliance with Github's node@12 deprecation. I believe the following warning is due to these actions being out of date.

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: preactjs/compressed-size-action@2.5.0. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

I don't think #87 fully solved this problem

From the link:

Node 12 has been out of support since April 2022, as a result we have started the deprecation process of Node 12 for GitHub Actions. We plan to migrate all actions to run on Node16 by Summer 2023. We will monitor the progress of the migration and listen to the community for how things are going before we define a final date.
To raise awareness of the upcoming change, we are adding a warning into workflows which contain Actions running on Node 12. This will come into effect starting on September 27th.

In my own projects I updated these actions to the latest major versions and the deprecation warning went away.

I imagine this change would be a major version upgrade as I had to add these new versions to my project's allowed list of actions, otherwise I receive this warning and the actions fail to execute.

Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following < list of existing actions >

@mmckenziedev mmckenziedev marked this pull request as ready for review April 18, 2023 17:33
@mmckenziedev
Copy link
Contributor Author

@estherkim Did you previous PR solve your deprecation warning?

@mmckenziedev
Copy link
Contributor Author

@developit @JoviDeCroock Please review?

@JoviDeCroock
Copy link
Member

Are you seriously tagging me for something you just opened?

@mmckenziedev
Copy link
Contributor Author

Are you seriously tagging me for something you just opened?

I don't know who reviews changes in this repo. You approved the last PR that was supposed to resolve this issue so you seemed like a likely candidate? Sorry if I broke some protocol.

@rschristian
Copy link
Member

Tagging people is generally a way to get attention if something has gone unnoticed for a while. Most of us have some sort of notifications set up and will get to things eventually.

So tagging specific people for a review less than 10 minutes after opening can be seen as a bit rude in any OSS project, as maintaining this stuff isn't our day job or anything we're really paid for. It's something we do in our free time, when we can. It comes off as a bit demanding, which is what I think Jovi was hinting at.

Rest assured, someone will take a look eventually.

@JoviDeCroock JoviDeCroock merged commit 8a15fc9 into preactjs:master Apr 23, 2023
1 check passed
renovate bot added a commit to SAP/ui5-webcomponents-react that referenced this pull request Apr 23, 2024
…5748)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[preactjs/compressed-size-action](https://togithub.com/preactjs/compressed-size-action)
| action | minor | `2.5.0` -> `2.6.0` |

---

### Release Notes

<details>
<summary>preactjs/compressed-size-action
(preactjs/compressed-size-action)</summary>

###
[`v2.6.0`](https://togithub.com/preactjs/compressed-size-action/releases/tag/2.6.0)

[Compare
Source](https://togithub.com/preactjs/compressed-size-action/compare/2.5.0...2.6.0)

#### New Features / Improvements

- \[feature] Add install script inputs by
[@&#8203;jeffreys-cat](https://togithub.com/jeffreys-cat) in
[preactjs/compressed-size-action#85
- feat: Add support for more precise percentage changes by
[@&#8203;mister-ben](https://togithub.com/mister-ben) in
[preactjs/compressed-size-action#97
- Add support for Bun by
[@&#8203;jack-weilage](https://togithub.com/jack-weilage) in
[preactjs/compressed-size-action#104

#### Action Maintenance

- Update action.yml to use node16 by
[@&#8203;estherkim](https://togithub.com/estherkim) in
[preactjs/compressed-size-action#87
- Move to node20, release v3 by
[@&#8203;jonny-puma](https://togithub.com/jonny-puma) in
[preactjs/compressed-size-action#103

#### Repo Maintenance

- Fix typo by [@&#8203;denniskigen](https://togithub.com/denniskigen) in
[preactjs/compressed-size-action#86
- chore: Update Github actions to latest versions by
[@&#8203;mmckenziedev](https://togithub.com/mmckenziedev) in
[preactjs/compressed-size-action#90
- chore: Bump package-lock.json by
[@&#8203;rschristian](https://togithub.com/rschristian) in
[preactjs/compressed-size-action#105

#### New Contributors

- [@&#8203;denniskigen](https://togithub.com/denniskigen) made their
first contribution in
[preactjs/compressed-size-action#86
- [@&#8203;estherkim](https://togithub.com/estherkim) made their first
contribution in
[preactjs/compressed-size-action#87
- [@&#8203;mmckenziedev](https://togithub.com/mmckenziedev) made their
first contribution in
[preactjs/compressed-size-action#90
- [@&#8203;jack-weilage](https://togithub.com/jack-weilage) made their
first contribution in
[preactjs/compressed-size-action#104
- [@&#8203;jonny-puma](https://togithub.com/jonny-puma) made their first
contribution in
[preactjs/compressed-size-action#103
- [@&#8203;mister-ben](https://togithub.com/mister-ben) made their first
contribution in
[preactjs/compressed-size-action#97
- [@&#8203;jeffreys-cat](https://togithub.com/jeffreys-cat) made their
first contribution in
[preactjs/compressed-size-action#85
- [@&#8203;rschristian](https://togithub.com/rschristian) made their
first contribution in
[preactjs/compressed-size-action#105

**Full Changelog**:
preactjs/compressed-size-action@2.5.0...2.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/SAP/ui5-webcomponents-react).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants