Skip to content

Commit

Permalink
Bump Node.js version to 18.14.0 and Go to 1.21.1
Browse files Browse the repository at this point in the history
On riscv64, nodeenv will pull binary from unofficial-builds [1], and
unfortunately 18.13.0 seems to be the only version above 18 that is
missing riscv64 builds. Shifting the version slightly to make test work.

Go's binary now ships with linux/riscv64 binary since 1.21.
  • Loading branch information
hack3ric committed Sep 25, 2023
1 parent 84f9164 commit 5e05b01
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/languages/golang_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ def test_golang_versioned(tmp_path):
tmp_path,
golang,
'go version',
version='1.18.4',
version='1.21.1',
)

assert ret == 0
assert out.startswith(b'go version go1.18.4')
assert out.startswith(b'go version go1.21.1')


def test_local_golang_additional_deps(tmp_path):
Expand Down
2 changes: 1 addition & 1 deletion tests/languages/node_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def test_node_with_user_config_set(tmp_path):
test_node_hook_system(tmp_path)


@pytest.mark.parametrize('version', (C.DEFAULT, '18.13.0'))
@pytest.mark.parametrize('version', (C.DEFAULT, '18.14.0'))
def test_node_hook_versions(tmp_path, version):
_make_hello_world(tmp_path)
ret = run_language(tmp_path, node, 'node-hello', version=version)
Expand Down

0 comments on commit 5e05b01

Please sign in to comment.