Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tomli and tomllib instead of toml #771

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

DanielNoord
Copy link
Contributor

Closes #755.

Originally this switch was rejected because the hope was that toml would be updated at one point, see #608. However, the latest commit is from 1 November 2020 (commits) and tomli will be part of Python 3.11 so it seems like a good candidate to replace it.

Similar PRs have been used in other "mainstream" projects like python/mypy#12305 and pytest-dev/pytest#9741.

@DanielNoord
Copy link
Contributor Author

CI seems to fail because of lack of coverage on L8. I could add a pragma: no cover comment if desired.

@asottile
Copy link
Member

the correct pragmas would be # pragma: >=3.11 cover and # pragma: <3.11 cover

@DanielNoord
Copy link
Contributor Author

DanielNoord commented May 31, 2022

the correct pragmas would be # pragma: >=3.11 cover and # pragma: <3.11 cover

Added and passing! 😄

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 2b6a486 into pre-commit:main May 31, 2022
@DanielNoord DanielNoord deleted the tomli branch May 31, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support newer TOML syntax
2 participants