Move midi initialisation to a thread #5839
Merged
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIDI is rarely used. On top of that, on macOS the overhead on first call to the `Devices` enum is very expensive (>1s). This shouldn't delay startup of the game. Implementation is copied from `OpenTabletDriveHandler`, which should be quite reliable.
|
Is the |
|
Hold off, this is really dodgy. |
yes. |
|
After 06d630b:
Both profile sessions are over 10 seconds, which gives enough time for |
smoogipoo
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIDI is rarely used. On top of that, on macOS the overhead on first call to the
Devicesenum is very expensive (>1s). This shouldn't delay startup of the game.Implementation is copied from
OpenTabletDriveHandler, which should be quite reliable.