Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Veldrid package to revert CADisplayLink implementation from veldrid-side #5826

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

frenzibyte
Copy link
Member

2023-06-08 05:38:37 [verbose]: 🖼️ Initialising "Veldrid" renderer with "Metal" surface
2023-06-08 05:38:37 [verbose]: Updated display mode to desktop resolution: 844x390@60, SDL_PIXELFORMAT_ABGR8888
2023-06-08 05:38:37 [verbose]: 🖼️ Renderer initialisation failed with:
2023-06-08 05:38:37 [verbose]: System.EntryPointNotFoundException: createDisplayLinkProxy
2023-06-08 05:38:37 [verbose]: at Veldrid.MetalBindings.CADisplayLinkProxy.InitWithCallback(IntPtr callback)
2023-06-08 05:38:37 [verbose]: at Veldrid.MTL.MTLCADisplayLink..ctor()
2023-06-08 05:38:37 [verbose]: at Veldrid.MTL.MTLGraphicsDevice..ctor(GraphicsDeviceOptions options, Nullable`1 swapchainDesc, MetalDeviceOptions metalOptions)
2023-06-08 05:38:37 [verbose]: at Veldrid.MTL.MTLGraphicsDevice..ctor(GraphicsDeviceOptions options, Nullable`1 swapchainDesc)
2023-06-08 05:38:37 [verbose]: at Veldrid.GraphicsDevice.CreateMetal(GraphicsDeviceOptions options, SwapchainDescription swapchainDescription)
2023-06-08 05:38:37 [verbose]: at osu.Framework.Graphics.Veldrid.VeldridRenderer.Initialise(IGraphicsSurface graphicsSurface)
2023-06-08 05:38:37 [verbose]: at osu.Framework.Graphics.Rendering.Renderer.osu.Framework.Graphics.Rendering.IRenderer.Initialise(IGraphicsSurface graphicsSurface)
2023-06-08 05:38:37 [verbose]: at osu.Framework.Platform.GameHost.SetupRendererAndWindow(IRenderer renderer, GraphicsSurfaceType surfaceType)
2023-06-08 05:38:37 [important]: The selected renderer (Metal) failed to initialise. Renderer selection has been reverted to automatic.

Latest Veldrid bump unintentionally included half-working changes on iOS. This bumps Veldrid again to a version that has those changes reverted. See discord.

<PackageReference Include="ppy.Veldrid" Version="4.9.3-gd4340776eb" />
<PackageReference Include="ppy.Veldrid" Version="4.9.3-g31346ea477" />
Copy link
Contributor

@smoogipoo smoogipoo Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peppy Is this the correct version? You seem to have edited the discord message to direct to g36de67, but two versions were pushed close to each other.

4.9.3-g36de67dd68 (06:29:06Z)
4.9.3-g31346ea477 (07:01:22Z)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

31346ea points to the latest commit of master so it should be the correct one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were two different versions pushed, yep. The first was reverting the iOS change (ppy/veldrid@36de67d), the second was with frenzi's patch (ppy/veldrid@31346ea)

@peppy peppy self-requested a review June 8, 2023 10:32
@peppy peppy merged commit b5e8a9b into ppy:master Jun 8, 2023
@frenzibyte frenzibyte deleted the fix-metal-ios branch June 8, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants