Fix incorrect string validation for URL #1
Merged
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coditva
force-pushed
the
fix/url-string-validation
branch
from
77defa6
to
90f2b38
Compare
coditva
force-pushed
the
fix/url-string-validation
branch
from
90f2b38
to
cf6debd
Compare
codenirvana
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getCookiesandsetCookiefunctions can handle URL objects. They used to handle it in v4.0.0 but it seems since 4.1.1, validations were added which don't allow using URL object. PR salesforce#193This change updates the validations to allow both string and object.