-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved documentation & types #1849
Conversation
I have pushed the changes, they appear on my fork but not appearing here... @ai |
@@ -30,18 +30,21 @@ declare namespace Comment { | |||
export { Comment_ as default } | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* ``` | ||
*/ | ||
value: string | ||
|
||
/** | ||
* `true` if the declaration has an `!important` annotation. | ||
* The `important` property represents a boolean value. If true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove name duplication here as well
Strange. What we can try to fix the problem:
|
@vikaskaliramna07 - can you expand on the reasoning behind this? When an instance of Also you changed the jsdoc on the clone function to:
From what I can see in the code, there is no specific handling of |
this
toNode
, reason:this
is the reference to the original node, and having type of original node instance on a duplicated node instance is not correct method. click here to view