Fix node.parent.nodes type

postcss · Feb 6, 2024 · 5e7449f · 5e7449f
1 parent 65075df
commit 5e7449f
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/lib/at-rule.d.ts b/lib/at-rule.d.ts
@@ -1,4 +1,7 @@
-import Container, { ContainerProps } from './container.js'
+import Container, {
+  ContainerProps,
+  ContainerWithChildren
+} from './container.js'
 
 declare namespace AtRule {
   export interface AtRuleRaws extends Record<string, unknown> {
@@ -116,7 +119,7 @@ declare class AtRule_ extends Container {
    * ```
    */
   params: string
-  parent: Container | undefined
+  parent: ContainerWithChildren | undefined
 
   raws: AtRule.AtRuleRaws
 

diff --git a/lib/container.d.ts b/lib/container.d.ts
@@ -5,6 +5,12 @@ import Node, { ChildNode, ChildProps, NodeProps } from './node.js'
 import Rule from './rule.js'
 
 declare namespace Container {
+  export class ContainerWithChildren<
+    Child extends Node = ChildNode
+  > extends Container_<Child> {
+    nodes: Child[]
+  }
+
   export interface ValueOptions {
     /**
      * String that’s used to narrow down values and speed up the regexp search.

diff --git a/lib/declaration.d.ts b/lib/declaration.d.ts
@@ -1,4 +1,4 @@
-import Container from './container.js'
+import { ContainerWithChildren } from './container.js'
 import Node from './node.js'
 
 declare namespace Declaration {
@@ -79,7 +79,7 @@ declare class Declaration_ extends Node {
    */
   important: boolean
 
-  parent: Container | undefined
+  parent: ContainerWithChildren | undefined
 
   /**
    * The property name for a CSS declaration.

diff --git a/lib/rule.d.ts b/lib/rule.d.ts
@@ -1,4 +1,7 @@
-import Container, { ContainerProps } from './container.js'
+import Container, {
+  ContainerProps,
+  ContainerWithChildren
+} from './container.js'
 
 declare namespace Rule {
   export interface RuleRaws extends Record<string, unknown> {
@@ -70,7 +73,7 @@ declare namespace Rule {
  */
 declare class Rule_ extends Container {
   nodes: NonNullable<Container['nodes']>
-  parent: Container | undefined
+  parent: ContainerWithChildren | undefined
   raws: Rule.RuleRaws
   /**
    * The rule’s full selector represented as a string.

diff --git a/test/types.ts b/test/types.ts
@@ -4,7 +4,7 @@ const plugin: PluginCreator<string> = prop => {
   return {
     Declaration: (decl, { Comment, result }) => {
       if (decl.prop === prop) {
-        decl.warn(result, `${decl.prop} found`)
+        decl.warn(result, `${decl.prop} found in ${decl.parent?.nodes.length}`)
         decl.replaceWith(new Comment({ text: `${decl.prop} removed` }))
       }
     },