Configurable timeouts, background discovery #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephank
force-pushed
the
feat/auth-context
branch
2 times, most recently
from
39ebd26
to
2347001
Compare
stephank
force-pushed
the
feat/auth-context
branch
from
2347001
to
c296ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back background discovery, so that even if we hit the timeout, we can continue the HTTP requests and warm cache, in case the user performs another login later.
This also makes all of the timeouts configurable, and specifically adds timeouts to the HTTP client. It looks like there was no timeout by default, or maybe cancelling the future was an issue, but we were seeing "2 minute" response times for some webfinger requests, presumably some OS timeout.