Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependencies #876

Merged
merged 3 commits into from May 3, 2024
Merged

Reduce dependencies #876

merged 3 commits into from May 3, 2024

Conversation

stephank
Copy link
Member

This removes some dependencies:

  • Remove HTTP/2 support. I don't believe this is useful for the few outgoing requests we make. The h2 crate has seen only a couple of advisories from what I remember, but it is also ~18K SLOC talking to untrusted hosts, that doesn't bring us significant benefit.
  • Vendored the sd_notify bits we use. This also fixes the STOPPING notification, which I believe never worked. (The env var was unset by the READY notification.)
  • Replaced the matches crate with std::matches.
  • Removed our usage of lazy_static. Still used by dependencies.

@stephank stephank merged commit 0043fe4 into main May 3, 2024
4 checks passed
@stephank stephank deleted the feat/less-deps branch May 3, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant