Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 禁用缓存持久化时不自动创建目录;提供禁用配置中心的API #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WTIFS
Copy link
Contributor

@WTIFS WTIFS commented Jan 23, 2024

Please provide issue(s) of this PR:
Fixes #174

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@@ -61,9 +62,10 @@ type CacheFileInfo struct {
}

// NewCachePersistHandler create persistence handler
func NewCachePersistHandler(persistDir string, maxWriteRetry int,
func NewCachePersistHandler(persistEnable bool, persistDir string, maxWriteRetry int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接添加新的参数,这样不兼容以前的版本,可以改进兼容呢?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个只是插件,不对外暴露,没啥影响

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关闭持久化功能后,还是会自动创建 polaris/backup 文件夹
3 participants