perf(rust): faster str.contains literal matching in the small-string regime
#6811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
alexander-beedie
force-pushed
the
string-contains-performance
branch
from
9a72904
to
60c56a8
Compare
alexander-beedie
changed the title
str.contains literal matching in the small-string regimestr.contains literal matching in the small-string regime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up (ref: #6777).
The benchmarks are in, and the regex crate is victorious again... Using
reg.is_matchin all cases gets us equivalent or faster matching vsstr::containsfor small (<=96 char) strings, and cleaner code. The difference is even more pronounced for larger strings, but we already use the regex crate in that regime, so no changes there...Benchmark results