Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle implicit SQL string → temporal conversion in the BETWEEN clause #16279

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 16, 2024

Closes #16275.

(All the hard work was done in #15958, so this was a very quick win ;)

Example

df.sql("SELECT * FROM self WHERE dt BETWEEN '2020-01-01' AND '2002-02-02'")

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 16, 2024
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (11fe9d8) to head (eb29e92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16279      +/-   ##
==========================================
+ Coverage   80.80%   80.81%   +0.01%     
==========================================
  Files        1393     1393              
  Lines      179406   179408       +2     
  Branches     2921     2921              
==========================================
+ Hits       144971   144993      +22     
+ Misses      33932    33912      -20     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b21bd2d into pola-rs:main May 17, 2024
29 checks passed
@alexander-beedie alexander-beedie deleted the sql-string-temporal-between branch May 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering dates in SQL using BETWEEN raises a ComputeError
2 participants