-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct the error message for non-parquet file type and non-python api #15641
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #15641 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15641 +/- ##
=======================================
Coverage 81.30% 81.31%
=======================================
Files 1373 1373
Lines 176243 176244 +1
Branches 2544 2544
=======================================
+ Hits 143293 143310 +17
+ Misses 32466 32451 -15
+ Partials 484 483 -1 ☔ View full report in Codecov by Sentry. |
}, | ||
SinkType::File { file_type, .. } => { | ||
polars_bail!(InvalidOperation: | ||
"sink_{file_type:?} not yet supported in standard engine. Use 'collect().write_parquet()'" | ||
"sink_{file_type:?} not yet supported in standard engine." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can feature gate the error message. I want to keep the proper error message for python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what your intent is, is 6168f1f okay?
The current error message is incorrect under several conditions and is worth correcting.
write_parquet()
etc. does not exist in Rust.write_parquet()
for file formats other than Parquet.It could be changed to a longer error message including what to do in Rust and in Python, respectively, but I thought a shorter error message would be preferred here, given the other sections.