fix(git-resolver): wrong scheme to git ls-remote
#6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
reviewed
Jul 14, 2023
resolving/git-resolver/test/index.ts
Outdated
Comment on lines
415
to
421
| expect(resolveResult).toStrictEqual({ | ||
| id: '0000000000000000000000000000000000000000+x-oauth-basic@github.com/foo/bar/0000000000000000000000000000000000000000', | ||
| normalizedPref: 'git+https://0000000000000000000000000000000000000000:x-oauth-basic@github.com/foo/bar.git', | ||
| normalizedPref: 'github:foo/bar', | ||
| resolution: { | ||
| commit: '0000000000000000000000000000000000000000', | ||
| repo: 'https://0000000000000000000000000000000000000000:x-oauth-basic@github.com/foo/bar.git', | ||
| type: 'git', | ||
| tarball: 'https://codeload.github.com/foo/bar/tar.gz/0000000000000000000000000000000000000000', | ||
| }, | ||
| resolvedVia: 'git-repository', |
There was a problem hiding this comment.
but where is the auth token? This test is about a private git-hosted dependency that can only be downloaded with an auth token. But you have removed the auth token from the resolveResult.
There was a problem hiding this comment.
Fixing this bug involved more than I had imagine, I'll look into this next week.
There was a problem hiding this comment.
@zkochan It was HostedGit.shortcut() that removed the auth token.
zkochan
approved these changes
Jul 17, 2023
zkochan
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6805