-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granamic UI template #23
base: main
Are you sure you want to change the base?
Conversation
@Katerina-Chernevskaya oppened a new pull request after going through your instructions. Hope this is okay. |
It's been over two weeks since my submission, Is there a problem that i can fix? |
Hi @shaheerahmadch, |
Thank you so much for your prompt response @Katerina-Chernevskaya. Can you also go through my other 3 pull requests as well? I would Highly appreciate it. Incident Reporting, These are my other 3 pull requests. Thank you so much |
Hello @shaheerahmadch, Thank you for the submission! During our review, we encountered an issue: the attempt to create a zip file from the provided source code was unsuccessful, indicating that some components might be missing from the initial preparation. Could you kindly review and update the source code to address this issue? Also we'd like to ask you to enhance the README file, ensuring it aligns with our template. Your attention to these matters is greatly appreciated. We look forward to reviewing your updated submission. Regards, |
I'll take a look at the matter. Thanks for your response |
Hi @shaheerahmadch, I attempted to build a solution from the source code, but the attempt failed with the following error: It seems that in sourcecode\GranamicUITemplate\src\CanvasApps folder you miss src folder. Could you please check again the source code and update it? I also suggest you to upload source code into sourcecode folder directly without any subfolders like GranamicUITemplate\src. Thank you! |
Hello @Katerina-Chernevskaya, I have updated the source code and the readme file. I have testing on my end by creating a solution from the updated source code and importing the solution in a trial environment. Everything seems perfect on my end. You may check and merge. Thanks |
Hi @shaheerahmadch, Sorry, but the error still reproduced while I tried to compile the source code. Please check the source code. Thank you! Regards, |
Solution Details
What's in this Pull Request?