Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granamic UI template #23

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shaheerahmadch
Copy link
Contributor

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues? none

Solution Details

Q A
Solution requires premium license no
Solution uses experimental features (see licensing guidelines) no
Which connectors are used? none
Solution uses on-premises connectors? no
Solution uses custom connectors? no
Layout Tablet

What's in this Pull Request?

This pull request contains my canvas app template named Granamic UI Template. This app contains sample custom components that are built using HTML, CSS and Canvas App OOTB Controls.
Screenshot 2023-09-03 093448

@shaheerahmadch
Copy link
Contributor Author

@Katerina-Chernevskaya oppened a new pull request after going through your instructions. Hope this is okay.

@shaheerahmadch
Copy link
Contributor Author

It's been over two weeks since my submission, Is there a problem that i can fix?
Thanks

@Katerina-Chernevskaya
Copy link
Contributor

Hi @shaheerahmadch,
Thank you for your contribution and your patience!
We truly value your contribution. I'm currently working on reviewing your pull request and will provide feedback or merge it as soon as possible.

@shaheerahmadch
Copy link
Contributor Author

Thank you so much for your prompt response @Katerina-Chernevskaya. Can you also go through my other 3 pull requests as well? I would Highly appreciate it.

Incident Reporting,
Editable Subgrid
Chat Canvas App

These are my other 3 pull requests.

Thank you so much

@Katerina-Chernevskaya
Copy link
Contributor

Hello @shaheerahmadch,

Thank you for the submission!

During our review, we encountered an issue: the attempt to create a zip file from the provided source code was unsuccessful, indicating that some components might be missing from the initial preparation. Could you kindly review and update the source code to address this issue?

Also we'd like to ask you to enhance the README file, ensuring it aligns with our template.

Your attention to these matters is greatly appreciated. We look forward to reviewing your updated submission.

Regards,
Katerina Chernevskaya

@shaheerahmadch
Copy link
Contributor Author

I'll take a look at the matter. Thanks for your response ☺️

@shaheerahmadch
Copy link
Contributor Author

I tried a lot but i was unable to clone the solution using the following command:
pac solution clone --name GranamicUITemplate --outputDirectory sourceode --processCanvasApps

Even tried changing the Environment and creating the app again (Coping & Pasting controls from the original one).
But still got this error:
image

Then I tried the following command:
pac solution clone --name GranamicUITemplate --outputDirectory sourceode

It cloned the solution without any error.
I have now updated the solutions and also the source code

Note:
The canvas app contains custom components

@Katerina-Chernevskaya
Copy link
Contributor

Hi @shaheerahmadch,

I attempted to build a solution from the source code, but the attempt failed with the following error:
image

It seems that in sourcecode\GranamicUITemplate\src\CanvasApps folder you miss src folder.

Could you please check again the source code and update it? I also suggest you to upload source code into sourcecode folder directly without any subfolders like GranamicUITemplate\src.
Additionally, make sure to update the branch with the latest changes from the main branch.

Thank you!

@shaheerahmadch
Copy link
Contributor Author

Hello @Katerina-Chernevskaya, I have updated the source code and the readme file. I have testing on my end by creating a solution from the updated source code and importing the solution in a trial environment. Everything seems perfect on my end. You may check and merge. Thanks

@Katerina-Chernevskaya
Copy link
Contributor

Hi @shaheerahmadch,

Sorry, but the error still reproduced while I tried to compile the source code.
Please check that the source code was fully copied. Currently the folder 'src' is missed in the folder 'CanvasApps'. Look at the example of the source code structure of your another sample 'editable subgrid':
image

Please check the source code.

Thank you!

Regards,
Katerina Chernevskaya

@aprildunnam aprildunnam added the Needs Attention Something needs to be fixed with the PR before merging label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention Something needs to be fixed with the PR before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants