Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: 'm365 entra pim role assignment eligibility list'. Closes #5783 #5973

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

New command: 'm365 entra pim role assignment eligibility list'. Closes #5783 #5973

wants to merge 3 commits into from

Conversation

MartinM85
Copy link
Contributor

Closes #5783

@milanholemans
Copy link
Contributor

Thanks @MartinM85! We'll try to look at it ASAP!

@MathijsVerbeeck MathijsVerbeeck self-assigned this May 25, 2024
@MathijsVerbeeck
Copy link
Contributor

@MartinM85 Great start. I have added some remarks, but it seems that I did an oopsie so they are listed quite strange. Could you please have a look at them?

@MathijsVerbeeck MathijsVerbeeck marked this pull request as draft May 25, 2024 11:34
@MartinM85
New command: 'm365 entra pim role assignment eligibility list' - Retr…
79029c9 
…ieves a list of roles a user or group is eligible to be assigned
@MartinM85
New command: 'm365 entra pim role assignment eligibility list' - Retr…
9ff9c90 
…ieves a list of roles a user or group is eligible to be assigned
@MartinM85 MartinM85 force-pushed the feature/5783-pim-role-assignment-eligibility-list branch from fd1ec8e to 9ff9c90 Compare May 25, 2024 18:06
@MartinM85
Copy link
Contributor Author

@MathijsVerbeeck Thank you for the feedback. All comments resolved.
At the first sight I don't see any issue when retrieving assignments. Could you include more details?

@MartinM85 MartinM85 marked this pull request as ready for review May 25, 2024 18:14
@MathijsVerbeeck
Copy link
Contributor

@MathijsVerbeeck Thank you for the feedback. All comments resolved.

At the first sight I don't see any issue when retrieving assignments. Could you include more details?

I was talking about my review. Your code was working fine!

I'll have another look ASAP.

MathijsVerbeeck
MathijsVerbeeck approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@MathijsVerbeeck MathijsVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor things that I'll fix when merging, but well done! I'll merge after the code freeze!

src/m365/entra/commands/pim/pim-role-assignment-eligibility-list.spec.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/pim/pim-role-assignment-eligibility-list.spec.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/pim/pim-role-assignment-eligibility-list.spec.ts Outdated Show resolved Hide resolved
@MartinM85
New command: 'm365 entra pim role assignment eligibility list' - Retr…
3a1c4df 
…ieves a list of roles a user or group is eligible to be assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathijsVerbeeck MathijsVerbeeck MathijsVerbeeck approved these changes

Assignees

@MathijsVerbeeck MathijsVerbeeck

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MartinM85 @milanholemans @MathijsVerbeeck