Removes trailing slashes from 'spo get' #5929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have this in a lot of other places as well:
Maybe something for another day. |
|
Good catch. We should definitely trim that |
milanholemans
force-pushed
the
sposet-trailingslash
branch
from
5c879e2
to
6221f44
Compare
|
@martinlingstuyl, I made a small update to this PR. In #5955 we introduced a new util function |
martinlingstuyl
approved these changes
May 7, 2024
|
Merged manually, thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the CLI, I used
spo setcommand. I just copied the tenant URL from my browser and noticed it has a trailing slash. While the API requests are still working, it doesn't look nice in the debug logs.I also enforced that the URL parameter is a string.