New command: viva engage community get. Closes #5754

[Saurabh7019]

Closes #5754

[milanholemans]

Thanks @Saurabh7019! We'll try to review it ASAP.

[Saurabh7019]

Hi @milanholemans , The PR is failing due to the error below. Have you encountered this issue before?

/home/runner/work/cli-microsoft365/cli-microsoft365/src/m365/viva/commands/engage/engage-community-get.ts
Error: 16:7 error 'VivaEngageCommunityGetCommand' is not a valid command class name. Expected 'VivaEngageCommUnitYGetCommand' cli-microsoft365/correct-command-class-name

[milanholemans]

Hi, @Saurabh7019 this is because we are using a dictionary to enforce a correct naming of commands in CLI.
You can find the dictionary here:

cli-microsoft365/.eslintrc.cjs

Lines 3 to 11 in 443bfd8

	const dictionary = [
	'access',
	'activation',
	'activations',
	'adaptive',
	'administrative',
	'ai',
	'app',
	'application',

In this case, I think we should add the word community.

[milanholemans]

Hi @Saurabh7019, could you rebase with the latest main to resolve the merge conflict, please?

[Saurabh7019]

Done!

[milanholemans]

Nice start @Saurabh7019, made a few comments while reviewing, could you have a look at them, please?

[milanholemans]

Since this is a Graph command, we don't have to show this warning.

[Saurabh7019]

I may not have fully understood this. I have removed the "cli consent" part since it was not included in the issue spec. Please let me know if any other changes are needed.

[milanholemans]

Hi @Saurabh7019, yes the consent part was not needed. For other viva engage commands we use the Yammer API which requires this consent. Since this command is built on Graph, we don't have to show this warning here.