Enhances flow get
#5913
Enhances flow get
#5913
Conversation
|
Thank you @MathijsVerbeeck, we'll try to review it soon. |
MathijsVerbeeck
force-pushed
the
enhance-flow-get-with-expand
branch
from
cc04e86
to
7fefee5
Compare
|
@martinlingstuyl I've changed your requests. Could you please have another look? |
|
About that mock file @MathijsVerbeeck, that now seems to contain 14000+ lines. Is it an idea if we use the same json as used in the docs? To get down on the nr of lines? |
That wouldn't cover all 'branches' of code, as we add some things to the response at lines 103-104 in flow-get.ts, so then we wouldn't have all code coverage 😄 |
|
Ok, I see... maybe we could switch it to a manual trigger though? That would remove quite some code I believe, among other things the whole connectionReferences node. |
|
We could, yes, but then I perhaps will have to add a part that tests this code manually to the mock. Is that fine? |
|
@martinlingstuyl PR should be ready to review. I've changed the flow-get mock file. |
There was a problem hiding this comment.
Looks fine @MathijsVerbeeck. 👏 Much better like this also in terms of changed lines.
| @@ -10,8 +10,10 @@ import { session } from '../../../utils/session.js'; | |||
| import { sinonUtil } from '../../../utils/sinonUtil.js'; | |||
| import commands from '../commands.js'; | |||
| import command from './flow-get.js'; | |||
|
|
|||
| import { flowGetResponse } from './flow-get.mock.js'; | |||
| describe(commands.GET, () => { | |||
There was a problem hiding this comment.
Let's add an extra white line above describe
Closes #4683
I did not update the doc file with the entire output of a command, as this can get very long. I ran the command with
--output jsonon a very small flow with just four actions and it returned more than 15000 lines of details. This would make the doc file way too large I think.