Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds CLI for Microsoft 365 v6.1 release article #836

Merged
merged 3 commits into from Dec 31, 2022
Merged

Adds CLI for Microsoft 365 v6.1 release article #836

merged 3 commits into from Dec 31, 2022

Conversation

Adam-it
Copy link
Collaborator

@Adam-it Adam-it commented Dec 27, 2022

Category

  • New article

Contents of the Pull Request

This PR adds a new release article of CLI for Microsoft v6.1 beta

@Adam-it
Copy link
Collaborator Author

Adam-it commented Dec 27, 2022

@pnp/cli-for-microsoft-365-maintainers please do double check 🙏.

waldekmastykarz
waldekmastykarz requested changes Dec 27, 2022
View reviewed changes
Copy link
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's do a few adjustments 👏

content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
milanholemans
milanholemans suggested changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Adam-it!

content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Show resolved Hide resolved
Jwaegebaert
Jwaegebaert approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Adam-it. I've left a few suggestions for possible typo fixes 😄

content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
content/cli-for-microsoft-365/cli-for-microsoft-365-v6-1/index.md Outdated Show resolved Hide resolved
@martinlingstuyl
Copy link
Contributor

Also one comment from me on retention labels. Great work Adam!

@Adam-it Adam-it marked this pull request as ready for review December 30, 2022 22:08
@Adam-it
Copy link
Collaborator Author

Adam-it commented Dec 30, 2022

thanks @waldekmastykarz , @Jwaegebaert , @milanholemans , @martinlingstuyl for your great reviews 👍
I resolved your comments. It seems to me to be more or less ready 😉

@waldekmastykarz waldekmastykarz merged commit 0378be6 into pnp:main Dec 31, 2022
@Adam-it Adam-it deleted the cli-for-microsoft365-release-6-1 branch February 27, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl requested changes

@milanholemans milanholemans milanholemans requested changes

@waldekmastykarz waldekmastykarz waldekmastykarz approved these changes

@Jwaegebaert Jwaegebaert Jwaegebaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Adam-it @martinlingstuyl @waldekmastykarz @milanholemans @Jwaegebaert