-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics: Add Copilot audit events to the Power BI report #4
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the comments regarding a missing table.
[user_id], @StartDate, | ||
SUM([copilot_chats_count]), SUM([copilot_meetings_count]), SUM([copilot_files_count]) | ||
|
||
FROM dbo.[copilot_activity_log] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table does not exist in the dbo schema.
You could use a new temporary table that you fill in before this SELECT in order to prepare the metrics to be upserted.
-- TODO | ||
[Copilot ChatsCount] BIGINT DEFAULT 0, | ||
[Copilot MeetingsCount] BIGINT DEFAULT 0, | ||
[Copilot FilesCount] BIGINT DEFAULT 0 | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use separate words for the metric names. Makes them friendlier and they don't need to be changed later in the report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review metrics in the incorrect table
[Copilot ChatsCount] [bit] NOT NULL DEFAULT 0, | ||
[Copilot MeetingsCount] [bit] NOT NULL DEFAULT 0, | ||
[Copilot FilesCount] [bit] NOT NULL DEFAULT 0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These metrics don't belong to this table. Only true/false metrics belong here.
No description provided.