Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add container refs #1771

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

kindoflew
Copy link
Collaborator

Why

Resolves #1770.

What

Added the DOM refs for the outer and inner div containers -- container and content respectively (as they were named pre-9.x.x). Also, updated docs and README to reflect changes.

Checklist

  • Documentation updated
  • Ready to be merged

For the docs, I updated the organization a little bit and made a "ref Properties" section that includes these two refs, as well as the scrollTo method. It just seemed to stand out a little bit more, as opposed to a list (although, I suppose it could also be a table 🤔 ).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vercel
Copy link

vercel bot commented Nov 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/6ab4v2GjayBfxPFM9msWe7K43qLT
✅ Preview: https://react-spring-io-git-feature-add-container-refs-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d66b7ff:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
pmndrs/react-spring Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
spring-masonry Configuration
spring-animating-auto Configuration
pmndrs/react-spring Configuration
spring-chain Configuration
spring-svg-filter Configuration
pmndrs/react-spring Configuration
spring-tree Configuration
pmndrs/react-spring Configuration
initial-rocket Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration

@joshuaellis joshuaellis changed the base branch from master to release/9.4.0 December 1, 2021 22:26
@joshuaellis
Copy link
Member

Just pointing this at release/9.4.0

I will release this on beta tonight, cc @pvldsgn

@joshuaellis joshuaellis merged commit 286862c into release/9.4.0 Dec 1, 2021
@joshuaellis joshuaellis deleted the feature/add-container-refs branch December 1, 2021 22:27
@sampashas
Copy link

I look forward, thank you @joshuaellis, @kindoflew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get property container ref element - React-spring v9. ParallaxLayers. useRef
3 participants