New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Upgrade saxon to 12.4 #4959
Conversation
- The rewritten XPaths are slightly different, although equivalent
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think, we should also list this PR in the release notes under "misc".
@@ -94,13 +107,20 @@ static AxisIterator iterateList(List<? extends NodeInfo> nodes) { | |||
|
|||
@SuppressWarnings({"unchecked", "rawtypes"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this suppress warnings now? I see, that we now use generics...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... we can remove raw types, but still need unchecked
(NodeListIterator requires exactly NodeInfo
and not subtypes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try something, but in a separate PR...
Merge pull request #4959 from Monits:upgrade-saxon
Describe the PR
Saxon currently supports versions 10, 11 and 12. How long version 10 will remain to be supported is not clear, making the upgrade now gives us some future-proofing, while allowing us to benefit from further improvements in Saxon.
All changes are to internal classes, so this is backwards compatible.
Saxon 11+ and 12.1+ support Java 8+, so since PMD 7.0.0 there is no incompatibility on this front either.
Ready?
./mvnw clean verify
passes (checked automatically by github actions)