Change Contours size to be f64 instead of usize
#245
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added this under a new minor version in CHANGELOG.md, since it is a breaking change. Let me know if this should be changed. |
andrei-ng
approved these changes
Nov 12, 2024
|
Yes please (although I find it annoying that we need to bump the major number for such small changes, we night make other ppl unhappy 😁 ) Could you fix the tests as well please 🙏. |
rmburg
force-pushed
the
f64-contour-size
branch
from
af821de to
a9680db
Compare
andrei-ng
force-pushed
the
f64-contour-size
branch
from
a9680db to
7a93b07
Compare
andrei-ng
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the intervals between contour lines can only be integers.
I needed a smaller interval for a figure.
To Do: