Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip pointer position in hovermode x #6901

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

OBe95
Copy link
Contributor

@OBe95 OBe95 commented Feb 15, 2024

Fixes #6900

If I understood well the logic in hover.js when hovermode === 'x'

  • lx represents the center of the highlighted data point
  • there is a logic to adapt the tooltip box so that it doesn't go outside of the main-svg
  • this logic seems to misplace the center of the tooltip pointer

src/components/fx/hover.js Outdated Show resolved Hide resolved
src/components/fx/hover.js Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor

archmoj commented Feb 26, 2024

Great fix. 🥇
Two minor suggestions and please add draftlogs/6900_fix.md file as described here.
Thank you!

@OBe95
Copy link
Contributor Author

OBe95 commented Feb 26, 2024

Thanks for the review @archmoj

@OBe95 OBe95 force-pushed the fix-hovermode-x-tooltip-pointer branch 2 times, most recently from 604a558 to a1ddd19 Compare February 26, 2024 19:00
@archmoj
Copy link
Contributor

archmoj commented Feb 27, 2024

💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip pointer (triangle) not correctly positioned with hovermode 'x'
2 participants