Fixing issue #5350 by moving the 'false' check #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcjohnson I saw you were active on another recent PR. Any comments for this little one here? I don't see how I can assign reviewers or get a bit of attention for this one here... |
|
💃 |
|
@archmoj Any chance you guys can cut a release with this change so that I don't need to pull the master branch into my project? |
|
We expect to make a new release next week. Thanks for your contribution @andrej-vasilj! |
|
@andrej-vasilj FYI - We just released https://github.com/plotly/plotly.js/releases/tag/v2.26.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most minimal change that I could think of to maintain all existing functionality but to prevent canceled single click events from canceling the double click as well. This is my first PR to this project so let me know if I'm missing something.
Note that I had to modify one unit test because the way the code was before, it would call the single click handler even for double click events which the unit test took into account for the expected number of clicks.
type: bug