Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Croatian translation with messages and numeric format #6690

Merged
merged 10 commits into from Aug 11, 2023

Conversation

Mkranj
Copy link
Contributor

@Mkranj Mkranj commented Jul 28, 2023

Translated several options in Plotly modebar, as well as popup messages, into Croatian (hr) locale.

Review

I'd like to ask @krisbak1 as a native speaker to check the translation.

@Mkranj
Copy link
Contributor Author

Mkranj commented Jul 31, 2023

Improved translation of certain terms after @krisbak1 's comments.

@krisbak1
Copy link

krisbak1 commented Aug 1, 2023

Looks good now!

@Mkranj
Copy link
Contributor Author

Mkranj commented Aug 11, 2023

@archmoj Hi, could you please help me with the failing checks, or direct me to someone who can?
From what I'm seeing, flaky-no-gl-jasmine and webgl-jasmine are failing. The first one fails tests such as "[at]flaky should transition layout when one or more axis auto-ranged value changed", and the second one fails tests such as "[at]gl should fetch GeoJSON using URLs found in the traces".
This PR only updates a single localization file, so I wouldn't expect it to influence base Plotly behavior. Could there be an issue with CI/CD? Or somehow a more complex interaction between the localization file and the way Plotly processes charts?

@archmoj
Copy link
Contributor

archmoj commented Aug 11, 2023

💃
Thanks very much for the PR 🏆
This will be included in v2.25.2 patch shortly.

@archmoj archmoj merged commit a860a32 into plotly:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants