Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Non-Mapbox Scatter with text markers #6652

Merged
merged 5 commits into from Jul 18, 2023
Merged

Fix Non-Mapbox Scatter with text markers #6652

merged 5 commits into from Jul 18, 2023

Conversation

TillerBurr
Copy link
Contributor

Fixes #4110

Added glyphs as suggested in mapbox/mapbox-gl-js#4808

Any font from openmaptiles/fonts is acceptable to use as the textfont.

@TillerBurr
Copy link
Contributor Author

Not sure why the baselines failed. Only scattermapbox, mapbox.constants and scatter.text_defaults were modified, but scatter.text_defaults is only used with scatter type plots.

@archmoj
Copy link
Contributor

archmoj commented Jun 28, 2023

Not sure why the baselines failed. Only scattermapbox, mapbox.constants and scatter.text_defaults were modified, but scatter.text_defaults is only used with scatter type plots.

Thanks very much for the PR.

Considering a bug in our image test system we need to preserve the order of baseline creation in parallel runs.
For non mapbox baseline we suggest to use zz- at the start of mock & baseline names.
But since you added a new mapbox mock in this PR and we want to allow some tolerance for mapbox, you need to download (from here & replace these new baselines inside test/image/baseline folder.
That should help tests go green.
Thank you!

archmoj
archmoj reviewed Jun 28, 2023
View reviewed changes
draftlogs/6652_fix.md Outdated Show resolved Hide resolved
TillerBurr and others added 2 commits June 28, 2023 11:26
@TillerBurr @archmoj
Update draftlogs/6652_fix.md
b76c734 
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
@TillerBurr
add supportedFonts, default to 'Open Sans Regular' if not found
bf674e1
@archmoj
Copy link
Contributor

archmoj commented Jul 18, 2023

💃

@archmoj archmoj merged commit 2effef5 into plotly:master Jul 18, 2023
1 check passed
@TillerBurr TillerBurr mentioned this pull request Apr 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj archmoj left review comments

Assignees
No one assigned
Labels
status: reviewable type: bug type: community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scattermapbox: text not displayed when using non-mapbox predefined styles
2 participants
@TillerBurr @archmoj