Fix heatmap/image traces without zsmooth on Safari/iOS #6605
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
added
bug
Co-authored-by: Alex Johnson <alex@plot.ly>
lvlte
changed the title
archmoj
reviewed
May 15, 2023
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
archmoj
reviewed
May 15, 2023
|
For the plotly.js/src/traces/image/plot.js Line 15 in 18b5097 |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6604
Safari doesn't behave consistently with pixelated image-rendering (depends on whether the target object is an
<image>or an<img>, whether there is a transform applied on the object, etc.) although it's supposed to support it and even though it passes the css support test. It seems like a webkit bug (it should not pass the css support test) ?So I guess the best option for now is to prevent the pixelated rendering optimization on Safari.