-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exporting patterns with transparent color #6318
Conversation
Looks like pattern plotly.js/src/components/drawing/index.js Line 530 in adcb081
But I wonder: is there any difference in effect between Also: looks like the plotly.js/src/components/drawing/index.js Line 571 in adcb081
|
Browser compatibility of |
stroke-opacity
We've been using those attributes all over the place for years, I think we can conclude they're safe :) But simpler is better as long as the effect is the same. Did anything actually change in the images you regenerated? They look identical to me. We still want to separate out |
With that said, do you think it would be better (& more specific) to use |
You could also say |
Good call. Addressed in 4cd8011. |
@alexcjohnson Let's merge this PR so I possibly open another one for few other components & traces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Yep, looks great!
@plotly/plotly_js