Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scattergl traces to the strict bundle #5444

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 25, 2021

Thanks to @mikolalysenko, @tdelmas and @bpostlethwaite,
this PR bumps the version of binary-search-bounds from v2.0.4 to v2.0.5 and adds scattergl, splom and scatterpolargl traces to the strict bundle. cc: #897, #5395.

Please note we still use version 1 of binary-search-bounds in certain packages which mostly impacted gl[2/3]d traces.
I opened four PRs (as listed in #897) to bump binary-search-bounds at v2 in those sub-modules.
We could upgrade those in a separate pull once new patches become available.

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 25, 2021
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good progress!

@archmoj archmoj merged commit c8e969b into master Jan 25, 2021
@archmoj archmoj deleted the bump-binary-search-bounds branch January 25, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants