Merge pull request #6684 from plotly/fix-double-click-unhide

Fix isolated state detection in multi legend case
plotly · Jul 25, 2023 · 9c9d5d0 · 9c9d5d0
2 parents e0e79b4 + dc17d3b
commit 9c9d5d0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/draftlogs/6684_fix.md b/draftlogs/6684_fix.md
@@ -0,0 +1,2 @@
+ - Fix unhide isolated traces in multi legend cases (regression introduced in 2.24.3) [[#6684](https://github.com/plotly/plotly.js/pull/6684)]
+
diff --git a/src/components/legend/handle_click.js b/src/components/legend/handle_click.js
@@ -198,7 +198,7 @@ module.exports = function handleClick(g, gd, numClicks) {
 
                 isInGroup = (hasLegendgroup && fullData[i].legendgroup === legendgroup);
 
-                if(!isInGroup && fullData[i].visible === true && !Registry.traceIs(fullData[i], 'notLegendIsolatable')) {
+                if(fullData[i].legend === thisLegend && !isInGroup && fullData[i].visible === true && !Registry.traceIs(fullData[i], 'notLegendIsolatable')) {
                     isIsolated = false;
                     break;
                 }

diff --git a/test/jasmine/tests/legend_test.js b/test/jasmine/tests/legend_test.js
@@ -1915,6 +1915,14 @@ describe('legend interaction', function() {
                 Promise.resolve()
                     .then(click(0, 2))
                     .then(assertVisible([false, true, true, false, 'legendonly', true]))
+
+                    // isolate it
+                    .then(click(0, 2))
+                    .then(assertVisible([false, true, 'legendonly', false, 'legendonly', true]))
+
+                    // unhide it again
+                    .then(click(0, 2))
+                    .then(assertVisible([false, true, true, false, 'legendonly', true]))
                     .then(done, done.fail);
             });
         });