Update to jupyter_server 2.11.0 API #1145
Conversation
Added md5 parameter to PloomberContentsManager.get and passed it along to super calls.
|
|
|
I will add another commit to support <2.11 and >2.11 |
|
@marr75 thanks for working on this! how are you thinking of supporting both versions? if the code gets too complicated, we can just require >2.11 for the next ploomber release |
|
Jupyter server 2.11.0 has been yanked, I'm trying to make this change compatible: jupyter-server/jupyter_server#1367 This may require you to make additional changes. Sorry to bring this up... |
jupyter_server committers are looking to support variable hash algorithms so the variable name has changed. Introducing *args and **kwargs and forwarding them to super should make this work with <2.11 and somewhat future proof the signature.
|
|
|
I went with something simpler. Just forwarding *args and **kwargs to the super method. |
|
Tested with jupyter_server 2.10 and 2.12.dev0 |
|
@Wh1isper thanks for the heads up, the 2.12 change ended up spurring a simpler change from me anyway! |
|
Glad to hear it! |
|
@marr75 thanks a lot for your contribution! there's some minor CI issue we have fix (unrelated to this change), once we fix it, we'll release this. in the meantime, you can install from git |
|
@marr75 this has been released in version 0.23.1! |
Added md5 parameter to PloomberContentsManager.get and passed it along to super calls.
Describe your changes
Small interface changes to adapt to 2.11.0 jupyter_server changes
Issue number
Closes #1144
Checklist before requesting a review
pkgmt format馃摎 Documentation preview 馃摎: https://ploomber--1145.org.readthedocs.build/en/1145/