Fix importing Middleware type alias #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Middleware was removed upstream in [#5898][0]. We can now use `Middleware` type alias from the typedefs starting from aiohttp 3.9.0 [0]: aio-libs/aiohttp#5898
|
Thanks a lot for the fix! My plan is to release new |
mprasil
commented
Nov 23, 2023
playpauseandstop
merged commit 2f772e7
into
playpauseandstop:main
9 of 10 checks passed
|
MERGED as is, once again thanks for contributing the fix. I'm about to add you to AUTHORS.rst list, please let me know if you have any objections. |
Merged
badabump-release-bot bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
Fixes: ------ - (**cors**) Fix typo in docstring (#150) - Fix importing Middleware type alias (#185) Other: ------ - Update Python dev version to 3.11.1 (#140) - (**deps**) bump certifi from 2022.9.24 to 2022.12.7 (#139) - Sync common project files (#141) - Monthly maintenance (Jan 2023) (#144) - (**deps**) Bump actions/checkout to 3.3.0 (#145) - Bump dev Python version to 3.11.2 (#151) - (**deps-dev**) Bump pytest from 7.2.0 to 7.2.1 (#146) - (**deps-dev**) Bump sphinx-autodoc-typehints from 1.19.5 to 1.22 (#147) - (**deps-dev**) Bump sphinxext-opengraph from 0.7.4 to 0.7.5 (#148) - (**dev-deps**) Update mypy from 0.991 to 1.0.1 (#153) - Fix another typo in docstring (#152) - Monthly maintenance (Apr 2023) (#163) - (**deps**) Bump actions/checkout from 3.3.0 to 3.5.0 (#161) - Monthly maintenance (Nov 2023) (#187) - Update some deps to latest Python 3.7 compatible versions (#188)
playpauseandstop
added a commit
that referenced
this pull request
Nov 23, 2023
Fixes: ------ - (**cors**) Fix typo in docstring (#150) - Fix importing Middleware type alias (#185) Other: ------ - Update Python dev version to 3.11.1 (#140) - (**deps**) bump certifi from 2022.9.24 to 2022.12.7 (#139) - Sync common project files (#141) - Monthly maintenance (Jan 2023) (#144) - (**deps**) Bump actions/checkout to 3.3.0 (#145) - Bump dev Python version to 3.11.2 (#151) - (**deps-dev**) Bump pytest from 7.2.0 to 7.2.1 (#146) - (**deps-dev**) Bump sphinx-autodoc-typehints from 1.19.5 to 1.22 (#147) - (**deps-dev**) Bump sphinxext-opengraph from 0.7.4 to 0.7.5 (#148) - (**dev-deps**) Update mypy from 0.991 to 1.0.1 (#153) - Fix another typo in docstring (#152) - Monthly maintenance (Apr 2023) (#163) - (**deps**) Bump actions/checkout from 3.3.0 to 3.5.0 (#161) - Monthly maintenance (Nov 2023) (#187) - Update some deps to latest Python 3.7 compatible versions (#188) Co-authored-by: playpauseandstop <playpauseandstop@users.noreply.github.com>
|
Thank you for quick merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Middlewarewas removed upstream in #5898. We can now useMiddlewaretype alias from the typedefs starting from aiohttp 3.9.0This leads to following error:
This change should be backwards compatible with older version of aiohttp.