Fix symlink package spec validation #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When validating symlink:// packages, use the specified symlink path, the same as for file:// packages. This fixes missing symlink packages in 'pkg list' and reinstalling on every build.
|
|
|
Thanks for the PR! |
ivankravets
added a commit
that referenced
this pull request
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing a library package, I tried to use a
symlink://specification in my test application to point to my library's development checkout. Unfortunately this seemed to cause a number of issues:platformio pkg listI traced this to the installed symlink package not matching its own pkg spec in
package/manager/base.py. It looks like it just needed the sameabspath()check as afile://specification.