Strict check #157
Strict check #157
Conversation
src/index.ts
Outdated
| if (typeof fetch !== 'undefined') { | ||
| this.config.fetch ||= fetch | ||
| if (!config.fetch && typeof fetch === 'undefined') { | ||
| throw new Error('No `fetch` implementation available') |
There was a problem hiding this comment.
To me, this is the only thing that seems like change in behavior.
So i understand, before if there was no fetch passed into the config and no global fetch available, we'd have not failed in the constructor, but failed later inside of postJSON when we tried to execute the undefined thing. Correct?
But our change here catches this in the constructor and yells before trying to use it.
There was a problem hiding this comment.
Correct. These days it's unlikely there's no fetch available but rather than have an internal Node exception bubble up. I wanted to fail fast with a clear exception message
There was a problem hiding this comment.
Changed this a little in ecae723.
this.fetch = config.fetch || fetch!This will raise a Uncaught ReferenceError: fetch is not define - which is easily googlable
Stronger type safety through
strictchecking