fix: use messageKey when giving message precedence over error
#1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmukuthu
changed the title
messageKey when giving msg precedence over errormessageKey when giving message precedence over error
|
Looks good, but we will need to rebase once #1747 is merged. |
|
Please rebase. That should make CI happy. |
Closed
renovate bot
added a commit
to fwouts/previewjs
that referenced
this pull request
Jul 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.14.1` -> `^8.14.2`](https://renovatebot.com/diffs/npm/pino/8.14.1/8.14.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.14.2`](https://togithub.com/pinojs/pino/releases/tag/v8.14.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.14.1...v8.14.2) #### What's Changed - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.16.14 to 20.2.3 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1718 - build(deps-dev): bump rimraf from 4.4.1 to 5.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1719 - build(deps-dev): bump pino-pretty from 9.4.0 to 10.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1670 - docs: add pino-slack-webhook to list of v7+ compatible transports by [@​youngkiu](https://togithub.com/youngkiu) in [pinojs/pino#1730 - Add missing closing curly brace in transports documentation by [@​JasoonS](https://togithub.com/JasoonS) in [pinojs/pino#1737 - Issue [#​1735](https://togithub.com/pinojs/pino/issues/1735) - Programmatic Integration as a transport fails by [@​altearius](https://togithub.com/altearius) in [pinojs/pino#1739 - build(deps-dev): bump typescript from 4.9.5 to 5.1.3 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1728 - build(deps-dev): bump bole from 4.0.1 to 5.0.5 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1734 - build(deps-dev): bump eslint-plugin-n from 15.7.0 to 16.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1740 - fix: browser respect child logger log level by [@​NicoVogel](https://togithub.com/NicoVogel) in [pinojs/pino#1725 - Fix dependency version by [@​jsumners](https://togithub.com/jsumners) in [pinojs/pino#1747 - fix: use `messageKey` when giving message precedence over error by [@​joelmukuthu](https://togithub.com/joelmukuthu) in [pinojs/pino#1746 #### New Contributors - [@​youngkiu](https://togithub.com/youngkiu) made their first contribution in [pinojs/pino#1730 - [@​JasoonS](https://togithub.com/JasoonS) made their first contribution in [pinojs/pino#1737 - [@​altearius](https://togithub.com/altearius) made their first contribution in [pinojs/pino#1739 - [@​NicoVogel](https://togithub.com/NicoVogel) made their first contribution in [pinojs/pino#1725 - [@​joelmukuthu](https://togithub.com/joelmukuthu) made their first contribution in [pinojs/pino#1746 **Full Changelog**: pinojs/pino@v8.14.1...v8.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to specfy/specfy
that referenced
this pull request
Aug 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.11.0` -> `8.15.0`](https://renovatebot.com/diffs/npm/pino/8.11.0/8.15.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.15.0`](https://togithub.com/pinojs/pino/releases/tag/v8.15.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.14.2...v8.15.0) #### What's Changed - docs(transports): add axiom [#​1753](https://togithub.com/pinojs/pino/issues/1753) by [@​qlaffont](https://togithub.com/qlaffont) in [pinojs/pino#1754 - Add pino-opentelemetry-transport as a known plugin to transports.md by [@​Vunovati](https://togithub.com/Vunovati) in [pinojs/pino#1757 - fix: example code in transports.md by [@​exKAZUu](https://togithub.com/exKAZUu) in [pinojs/pino#1761 - Add default levels to opts in multistream by [@​tzviki](https://togithub.com/tzviki) in [pinojs/pino#1760 #### New Contributors - [@​qlaffont](https://togithub.com/qlaffont) made their first contribution in [pinojs/pino#1754 - [@​Vunovati](https://togithub.com/Vunovati) made their first contribution in [pinojs/pino#1757 - [@​exKAZUu](https://togithub.com/exKAZUu) made their first contribution in [pinojs/pino#1761 - [@​tzviki](https://togithub.com/tzviki) made their first contribution in [pinojs/pino#1760 **Full Changelog**: pinojs/pino@v8.14.2...v8.15.0 ### [`v8.14.2`](https://togithub.com/pinojs/pino/releases/tag/v8.14.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.14.1...v8.14.2) #### What's Changed - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.16.14 to 20.2.3 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1718 - build(deps-dev): bump rimraf from 4.4.1 to 5.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1719 - build(deps-dev): bump pino-pretty from 9.4.0 to 10.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1670 - docs: add pino-slack-webhook to list of v7+ compatible transports by [@​youngkiu](https://togithub.com/youngkiu) in [pinojs/pino#1730 - Add missing closing curly brace in transports documentation by [@​JasoonS](https://togithub.com/JasoonS) in [pinojs/pino#1737 - Issue [#​1735](https://togithub.com/pinojs/pino/issues/1735) - Programmatic Integration as a transport fails by [@​altearius](https://togithub.com/altearius) in [pinojs/pino#1739 - build(deps-dev): bump typescript from 4.9.5 to 5.1.3 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1728 - build(deps-dev): bump bole from 4.0.1 to 5.0.5 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1734 - build(deps-dev): bump eslint-plugin-n from 15.7.0 to 16.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1740 - fix: browser respect child logger log level by [@​NicoVogel](https://togithub.com/NicoVogel) in [pinojs/pino#1725 - Fix dependency version by [@​jsumners](https://togithub.com/jsumners) in [pinojs/pino#1747 - fix: use `messageKey` when giving message precedence over error by [@​joelmukuthu](https://togithub.com/joelmukuthu) in [pinojs/pino#1746 #### New Contributors - [@​youngkiu](https://togithub.com/youngkiu) made their first contribution in [pinojs/pino#1730 - [@​JasoonS](https://togithub.com/JasoonS) made their first contribution in [pinojs/pino#1737 - [@​altearius](https://togithub.com/altearius) made their first contribution in [pinojs/pino#1739 - [@​NicoVogel](https://togithub.com/NicoVogel) made their first contribution in [pinojs/pino#1725 - [@​joelmukuthu](https://togithub.com/joelmukuthu) made their first contribution in [pinojs/pino#1746 **Full Changelog**: pinojs/pino@v8.14.1...v8.14.2 ### [`v8.14.1`](https://togithub.com/pinojs/pino/compare/v8.14.0...v8.14.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.14.0...v8.14.1) ### [`v8.14.0`](https://togithub.com/pinojs/pino/compare/c1c8eb41240c0ae9282bac1741ae2ee7bdb82895...v8.14.0) [Compare Source](https://togithub.com/pinojs/pino/compare/c1c8eb41240c0ae9282bac1741ae2ee7bdb82895...v8.14.0) ### [`v8.12.1`](https://togithub.com/pinojs/pino/compare/v8.12.0...c1c8eb41240c0ae9282bac1741ae2ee7bdb82895) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.12.0...c1c8eb41240c0ae9282bac1741ae2ee7bdb82895) ### [`v8.12.0`](https://togithub.com/pinojs/pino/compare/v8.11.0...v8.12.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.11.0...v8.12.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on friday,before 9am on monday,every weekend" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1654. Ref: https://github.com/pinojs/pino/pull/1654/files#r1270564181.