-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nested levelKey #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Even though this got approved, I've just realized that it may break things for those who assumed the dot notation handling does not apply to the
|
I think we might just go for a major. @jsumners wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some doc tweaks. I'm fine with a new major.
Co-authored-by: James Sumners <james@sumners.email>
@jsumners Applied |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`^9.4.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/pino-pretty/9.4.0/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/compatibility-slim/9.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/confidence-slim/9.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty</summary> ### [`v10.0.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.0.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v9.4.0...v10.0.0) #### What's Changed - Bump coverallsapp/github-action from 1.1.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#405 - Bump tsd from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#409 - Bump tsd from 0.26.1 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#413 - Support nested levelKey by [@​nikrabaev](https://togithub.com/nikrabaev) in [pinojs/pino-pretty#407 #### New Contributors - [@​nikrabaev](https://togithub.com/nikrabaev) made their first contribution in [pinojs/pino-pretty#407 **Full Changelog**: pinojs/pino-pretty@v9.4.0...v10.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/UK-Export-Finance/mdm-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->
I'll comment here, but tell me If it is best I create a new issue for this. This change may introduce an unexpected situation when using a nested level key. Using the https://github.com/pinojs/pino-pretty/blob/master/index.js#L189 |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`9.4.0` -> `10.0.0`](https://renovatebot.com/diffs/npm/pino-pretty/9.4.0/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/compatibility-slim/9.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/confidence-slim/9.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty</summary> ### [`v10.0.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.0.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v9.4.0...v10.0.0) #### What's Changed - Bump coverallsapp/github-action from 1.1.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#405 - Bump tsd from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#409 - Bump tsd from 0.26.1 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#413 - Support nested levelKey by [@​nikrabaev](https://togithub.com/nikrabaev) in [pinojs/pino-pretty#407 #### New Contributors - [@​nikrabaev](https://togithub.com/nikrabaev) made their first contribution in [pinojs/pino-pretty#407 **Full Changelog**: pinojs/pino-pretty@v9.4.0...v10.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/PKUHPC/SCOW). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`^9.4.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/pino-pretty/9.4.0/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/compatibility-slim/9.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/pino-pretty/10.0.0/confidence-slim/9.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty</summary> ### [`v10.0.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.0.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v9.4.0...v10.0.0) #### What's Changed - Bump coverallsapp/github-action from 1.1.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#405 - Bump tsd from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#409 - Bump tsd from 0.26.1 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#413 - Support nested levelKey by [@​nikrabaev](https://togithub.com/nikrabaev) in [pinojs/pino-pretty#407 #### New Contributors - [@​nikrabaev](https://togithub.com/nikrabaev) made their first contribution in [pinojs/pino-pretty#407 **Full Changelog**: pinojs/pino-pretty@v9.4.0...v10.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/UK-Export-Finance/nestjs-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->
This PR allows specifying the nested
levelKey
. Such keys will be treated just like theignore
nested keys.There are two reasons for this change:
ignore
option support nested keys andlevelKey
don't?level
is placed inside anothertags
object