Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: twice customProps #288

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: twice customProps #288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48b74a9
fix: twice customPropBindings
youngkiu Jun 11, 2023
a2f9cdd
Add unit test for twice customPropBindings
youngkiu Aug 2, 2023
6588779
Remove case insensitive in match regex
youngkiu Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const pino = require('pino')
const { pino, symbols: { stringifySym, chindingsSym } } = require('pino')
const serializers = require('pino-std-serializers')
const getCallerFile = require('get-caller-file')
const startTime = Symbol('startTime')
Expand Down Expand Up @@ -103,7 +103,11 @@ function pinoLogger (opts, stream) {

const customPropBindings = (typeof customProps === 'function') ? customProps(req, res) : customProps
if (customPropBindings) {
log = logger.child(customPropBindings)
const customPropBindingStr = logger[stringifySym](customPropBindings).replace(/[{}]/g, '')
const customPropBindingsStr = logger[chindingsSym]
if (!customPropBindingsStr.includes(customPropBindingStr)) {
log = logger.child(customPropBindings)
}
}

if (err || res.err || res.statusCode >= 500) {
Expand Down