Add grpc unit test run, expand testing of VectorFactory #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
ssmith-pc
approved these changes
Mar 22, 2024
| @@ -28,8 +28,11 @@ jobs: | |||
| with: | |||
| include_grpc: '${{ matrix.use_grpc }}' | |||
| include_types: true | |||
| - name: Run unit tests | |||
| - name: Run unit tests (REST) | |||
There was a problem hiding this comment.
I think these do cover the REST surface area, but also a lot of the "other" stuff like common utils, etc.
There was a problem hiding this comment.
Yeah. They're really meant to be "everything that doesn't require GRPC dependencies" unit tests. But that doesn't roll off the tongue 🤣
jhamon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a small number of unit tests that should only get run when grpc dependencies are installed. These were previously omitted from CI by mistake.
Solution
Add a step to run these grpc steps. Make it conditional on the
use_grpctest matrix param.Type of Change