upsert_from_dataframe: Hide all progressbars if !show_progress #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For GRPCIndex.upsert_from_dataframe() there is a second progressbar used when use_async_requests is true (the default) - 'collecting async responses'. However this progressbar is always shown, even if show_progress is false. Make it respect the show_progress argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For GRPCIndex.upsert_from_dataframe() there is a second progressbar
used when use_async_requests is true (the default) - 'collecting async
responses'. However this progressbar is always shown, even if
show_progress is false.
Solution
Make it respect the show_progress argument.
Type of Change