New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc unit test run, expand testing of VectorFactory #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! 🚢
Thanks! |
@@ -28,8 +28,11 @@ jobs: | |||
with: | |||
include_grpc: '${{ matrix.use_grpc }}' | |||
include_types: true | |||
- name: Run unit tests | |||
- name: Run unit tests (REST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these do cover the REST surface area, but also a lot of the "other" stuff like common utils, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. They're really meant to be "everything that doesn't require GRPC dependencies" unit tests. But that doesn't roll off the tongue 🤣
Problem
There is a small number of unit tests that should only get run when grpc dependencies are installed. These were previously omitted from CI by mistake.
Solution
Add a step to run these grpc steps. Make it conditional on the
use_grpc
test matrix param.Type of Change