Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegexArrayShapeMatcher - more precise subject types #3897

Merged
merged 17 commits into from
Mar 24, 2025
Merged

RegexArrayShapeMatcher - more precise subject types #3897

merged 17 commits into from
Mar 24, 2025
+364 −240

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 22, 2025

closes phpstan/phpstan#12749

I am aware that we are still not optimal and could be more precise in some cases, but I think its still a solid step forward

@staabm
Copy link
Contributor Author

staabm commented Mar 22, 2025 •
edited
Loading

I am aware that we are still not optimal and could be more precise in some cases, but I think its still a solid step forward

@gharlan @mvorisek @Seldaek could you double check the test expectations?

I likely overlooked something while adjusting all these expectations

gharlan
gharlan reviewed Mar 22, 2025
View reviewed changes
@staabm staabm force-pushed the preg-subj branch 2 times, most recently from 85e7b7c to d43ca1b Compare March 23, 2025 07:16
@staabm staabm marked this pull request as ready for review March 23, 2025 07:24
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@staabm
Copy link
Contributor Author

staabm commented Mar 23, 2025

(errors in nette are valid - expectations need updates)

Seldaek
Seldaek reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@Seldaek Seldaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a quick look👍🏻

staabm added 17 commits March 24, 2025 09:50
@staabm
RegexArrayShapeMatcher - more precise subject types

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ab5c826
@staabm
RegexArrayShapeMatcher - more precise subject types
a0388d5
@staabm
refactor
b1c5d37
@staabm
Update preg_match_shapes.php
Loading
Loading status checks…
bc88756
@staabm
Update RegexGroupParser.php
Loading
Loading status checks…
d16250d
@staabm
fix
Loading
Loading status checks…
80508d3
@staabm
tests
900f66f
@staabm
Delete test.php
196727b
@staabm
Update preg_replace_callback_shapes-php72.php
2260a95
@staabm
fix
4ca3128
@staabm
fix
4bb0da6
@staabm
fix
f4cb3ed
@staabm
Update NonexistentOffsetInArrayDimFetchRuleTest.php
708198b
@staabm
fix numeric string handling
df6fccf
@staabm
Update RegexGroupParser.php
9036121
@staabm
fix
caec1ce
@staabm
better method name
9040aaf
@staabm
Copy link
Contributor Author

staabm commented Mar 24, 2025

awesome, thank you all for reviewing.

@ondrejmirtes ondrejmirtes merged commit f2f2ddf into phpstan:2.1.x Mar 24, 2025
405 of 417 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the preg-subj branch March 24, 2025 13:26
@staabm staabm mentioned this pull request Mar 24, 2025
Merged
@mvorisek mvorisek mentioned this pull request Mar 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seldaek Seldaek

@gharlan gharlan

@mvorisek mvorisek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preg_match: non-empty-string for $match[0]
6 participants
@staabm @phpstan-bot @ondrejmirtes @Seldaek @gharlan @mvorisek