Skip to content

ResultCache: allow customization of params not invalidating cache #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

janedbal
Copy link
Contributor

  • Currently, I'm improving our dead-code-detector with some optional debug output.
  • This is configured via parameter that is wired to a Rule hooked to CollectedDataNode.
  • As this runs after parallel analysis is done, changing such parameter never affects result cache, but it gets invalidated anyway.
  • This PR solves this issue by providing configuration option where even phpstan extensions can mark their parameters as not affecting result cache.

@ondrejmirtes ondrejmirtes merged commit e169fde into phpstan:2.1.x Mar 12, 2025
408 of 417 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

1 similar comment
@janedbal
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants