Fix unsetting array item triggers unset.possiblyHookedProperty #3855
+194
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Mar 6, 2025
src/Rules/Variables/UnsetRule.php
Outdated
| @@ -48,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array | |||
| return $errors; | |||
| } | |||
|
|
|||
| private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError | |||
| private function canBeUnset(Node $node, Scope $scope, bool $inArrayDimFetch = false): ?IdentifierRuleError | |||
There was a problem hiding this comment.
More logical solution is to exclude $node instanceof Node\Expr\PropertyFetch section completely out of canBeUnset recursion and just check it directly in processNode.
The other part of this about unsetting on readonly property is also wrong so we need to fix that too:
There was a problem hiding this comment.
interessting..
Readonly properties cannot be unset() once they are initialized. However, it is possible to unset a readonly property prior to initialization, from the scope where the property has been declared.
|
This pull request has been marked as ready for review. |
|
I force-pushed what I meant instead. THank you. |
|
I see now. didn't got it in the first place. |
|
Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#12695