Skip to content

MissingTypehintCheck: reduce duplicate work #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 1, 2025

after PR

➜  phpstan-src git:(2.1.x) ✗ hyperfine 'php bin/phpstan analyze bug-12661.php --debug' -i
Benchmark 1: php bin/phpstan analyze bug-12661.php --debug
  Time (mean ± σ):      1.059 s ±  0.005 s    [User: 0.953 s, System: 0.102 s]
  Range (min … max):    1.053 s …  1.068 s    10 runs
 
  Warning: Ignoring non-zero exit code.
 

before this PR

➜  phpstan-src git:(2.1.x) ✗ hyperfine 'php bin/phpstan analyze bug-12661.php --debug' -i
Benchmark 1: php bin/phpstan analyze bug-12661.php --debug
  Time (mean ± σ):      1.111 s ±  0.019 s    [User: 0.993 s, System: 0.115 s]
  Range (min … max):    1.083 s …  1.151 s    10 runs
 
  Warning: Ignoring non-zero exit code.

on the reproducer of phpstan/phpstan#12661

grafik

@staabm staabm marked this pull request as ready for review March 1, 2025 08:50
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit a5e4bfa into phpstan:1.12.x Mar 1, 2025
311 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the red branch March 1, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants