Implement FinalPrivateConstantRule #3838
Merged
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
final-private
branch
from
8e07dbc to
1311fdd
Compare
staabm
commented
Feb 26, 2025
| { | ||
| $this->analyse([__DIR__ . '/data/final-private-const.php'], [ | ||
| [ | ||
| 'Private constant FinalPrivateConstants\User::FINAL_PRIVATE() cannot be final as it is not visible to other classes.', |
There was a problem hiding this comment.
used the error message from https://3v4l.org/oBYII
ondrejmirtes
requested changes
Feb 26, 2025
| $errors = []; | ||
| foreach ($node->consts as $classConstNode) { | ||
| $errors[] = RuleErrorBuilder::message(sprintf( | ||
| 'Private constant %s::%s() cannot be final as it is not visible to other classes.', |
There was a problem hiding this comment.
Please follow the method wording: Private method HelloWorld::sayHello() cannot be final as it is never overridden by other classes.
ondrejmirtes
requested changes
Feb 26, 2025
| 'Private constant %s::%s() cannot be final as it is never overridden by other classes.', | ||
| $classReflection->getDisplayName(), | ||
| $classConstNode->name->name, | ||
| ))->identifier('classConstant.finalPrivate')->build(); |
staabm
force-pushed
the
final-private
branch
from
f711356 to
c650a3c
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested in #3830 (review)