Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling an attempt to declare a hooked property static #3810

Merged

Conversation

jakubtobiasz
Copy link
Contributor

Fulfills Static properties cannot be hooked (ref: phpstan/phpstan#12336)

@jakubtobiasz jakubtobiasz force-pushed the static-properties-cannot-be-hooked branch from 8d4b70a to 70f0241 Compare February 5, 2025 19:31
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PropertiesInInterfaceRule should cover this too.

@jakubtobiasz
Copy link
Contributor Author

Done :)

@jakubtobiasz jakubtobiasz force-pushed the static-properties-cannot-be-hooked branch from 6c205a9 to a00961c Compare February 11, 2025 08:08

Verified

This commit was signed with the committer’s verified signature.
axlon Choraimy Kroonstuiver
@jakubtobiasz jakubtobiasz force-pushed the static-properties-cannot-be-hooked branch from a00961c to 376d521 Compare February 11, 2025 08:11
@ondrejmirtes ondrejmirtes merged commit b4f41c7 into phpstan:2.1.x Feb 11, 2025
41 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@jakubtobiasz jakubtobiasz deleted the static-properties-cannot-be-hooked branch February 11, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants